Skip to content

Add "script" to list of toggle-able domains#6996

Closed
ludeeus wants to merge 1 commit intodevfrom
toggle-script
Closed

Add "script" to list of toggle-able domains#6996
ludeeus wants to merge 1 commit intodevfrom
toggle-script

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Sep 14, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus changed the title Add "script" to list of toggle-able domains Use toggle as default if domain is script Sep 14, 2020
@zsarnett
Copy link
Copy Markdown
Contributor

Should we do this for auomations as well? or no? (I haven't looked at the Domains Array that it looks at for toggle either)

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Sep 14, 2020

automations is in DOMAINS_TOGGLE

@ludeeus ludeeus added this to the 0.115.0 milestone Sep 14, 2020
zsarnett
zsarnett previously approved these changes Sep 14, 2020
@ludeeus ludeeus marked this pull request as draft September 14, 2020 18:16
@ludeeus ludeeus changed the title Use toggle as default if domain is script Add "script" to list of toggle-able domains Sep 15, 2020
@ludeeus ludeeus marked this pull request as ready for review September 15, 2020 06:45
@ludeeus ludeeus dismissed zsarnett’s stale review September 15, 2020 06:46

Latest change was reverted

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Sep 15, 2020

Closed in favor of #7018

@ludeeus ludeeus closed this Sep 15, 2020
@ludeeus ludeeus deleted the toggle-script branch September 15, 2020 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button card doesn't execute script, shows more info

3 participants